Skip to content

Add macOS support to FaultOrdering package#12

Open
macshome wants to merge 1 commit intogetsentry:mainfrom
macshome:add-macos-support
Open

Add macOS support to FaultOrdering package#12
macshome wants to merge 1 commit intogetsentry:mainfrom
macshome:add-macos-support

Conversation

@macshome
Copy link

Hi there! I'm pretty excited to see this project open sourced. I wanted to see if it also worked to generate order files for macOS targets as that's mostly what I work with. It was easy to add the support, and the demo app generates the expected files with the UI Tests.

Because robots can do work for us now I had Copilot generate a description of all the details below:

This pull request introduces platform support for macOS in the FaultOrdering package, improves compatibility for Objective-C helpers, and refines code readability and correctness in test-related files. Below is a breakdown of the most important changes grouped by theme:

Platform Support:

  • Package.swift: Added macOS support (.macOS(.v13)) to the platforms section of the package definition. This expands the package's compatibility to macOS alongside iOS.

Compatibility Enhancements:

Code Refinements:

@macshome
Copy link
Author

macshome commented Nov 7, 2025

@trevor-e If this isn't something you guys want to pull I can close this PR and just use my fork.

@trevor-e
Copy link
Member

trevor-e commented Nov 7, 2025

@macshome sorry this slipped on our radar! Let me review this a bit more closely next week, at a glance the changes look reasonable though and supporting macOS would be great.

//

#if TARGET_OS_IOS
@import UIKit;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this import is actually used in the file, can we just delete it?

@noahsmartin
Copy link
Collaborator

Hey @macshome thanks for opening this and sorry for the delay! Just left one comment, could you update the PR to just have the changes for everything except Package.swift? Then we will make a new macos branch that includes the Package.swift target and also update the readme to make it clear that it's an experimental version that we aren't actively supporting. That way we can make it available through SPM while also making it clear that we don't have any plans to continue supporting macOS. Thanks!

@macshome
Copy link
Author

Hey. I just noticed this after a long delay of my own. I’ll look at making the requested changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants