This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Add environment variable switch for certificates.#150
Open
LeonLiuY wants to merge 1 commit intogetsentry:masterfrom
Open
Add environment variable switch for certificates.#150LeonLiuY wants to merge 1 commit intogetsentry:masterfrom
LeonLiuY wants to merge 1 commit intogetsentry:masterfrom
Conversation
Contributor
|
Could we not expose a method to set them? I imagine people also wanted to just explicitly give the certs to use. So something like, |
789fc5a to
6a41e92
Compare
Author
|
Neither is good smell to me. But I implemented the latter. PR is updated |
6a41e92 to
39a3370
Compare
|
Do you have any plans to merge this PR? |
Member
|
If we're still committed to this being a good (enough) implementation I'm happy to get this merged. In general it seems fine to me, and is probably nicer than an env variable. I do know the env variable pattern does exist elsewhere, but usually its for general "load certs from here". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the DefaultClient is created at package initialize phase, the only way to put this switch is environment variable.