This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Use cause in place of err in GetOrNewStacktrace#155
Merged
mattrobenolt merged 1 commit intogetsentry:masterfrom Nov 11, 2017
Merged
Use cause in place of err in GetOrNewStacktrace#155mattrobenolt merged 1 commit intogetsentry:masterfrom
mattrobenolt merged 1 commit intogetsentry:masterfrom
Conversation
Contributor
|
Thanks! 🍕 |
Contributor
|
@martinxsliu This causes any causes not created with the errors package to lose the stacktrace. Instead of passing the cause into GetOrNewStacktrace, we should instead recursively find the deepest cause that still has a stacktrace in GetOrNewStacktrace |
Contributor
Author
Contributor
|
@martinxsliu We are in sync it would seem haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks to @jsm and @mattrobenolt for getting the pkg/errors integration piece merged in #152!
This PR fixes an issue where the cause wasn't actually being passed into
GetOrNewStacktrace, meaning the generated stacktrace was of the last wrapped error rather than the originating one.This PR also adds the integration into the
CaptureErrorAndWaitmethod in addition to the currentCaptureError.