This repository was archived by the owner on Aug 30, 2023. It is now read-only.
feat: Add capture functions which takes fingerprint as parameter#245
Open
bohyunjung wants to merge 1 commit intogetsentry:masterfrom
bohyunjung:feat/support-fingerprint
Open
feat: Add capture functions which takes fingerprint as parameter#245bohyunjung wants to merge 1 commit intogetsentry:masterfrom bohyunjung:feat/support-fingerprint
bohyunjung wants to merge 1 commit intogetsentry:masterfrom
bohyunjung:feat/support-fingerprint
Conversation
Contributor
|
Thanks! That's too much of a change for me to review right now, as I'm working on https://github.com/getsentry/sentry-go/ which already has this feature, but I'll try to find some time soon to do that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raven-go did not support providing specified fingerprint which will be included in the packet that will be sent to the Sentry server. 6da7a07 introduces some new capturing functions that goes with the existing ones side-by-side, which takes
fingerprintparameter.This fixes #231.