This repository was archived by the owner on Aug 30, 2023. It is now read-only.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #9
Updated the data scrubbing code to allow for users to include their own custom processors. It also validates against a few more "bad keys" such as "authorization", "apikey", and "api_key." I took these keys from raven-python
I also added value validation to scrub out anything that looks like a credit card number.
Also it's now scrubbing HTTP Headers.
This is a more thorough implementation of: http://sentry.readthedocs.org/en/latest/developer/client/#scrubbing-data
Note: This is an API breaking change as NewClient now takes a ClientConfig struct to handle both tags/processors
Edit:
I wrote a processor_tests.go file that includes a test of the default processor and a custom provided one.