Merged
Conversation
Contributor
lforst
commented
Jan 24, 2025
lforst
commented
- Don't double encode urls for resources
- Name default export so that the codebase is less confusing
- Actually end response on unknown errors
- Transmit to client if an unknown error occurs
- Don't double encode urls for resources - Name default export so that the codebase is less confusing - Actually end response on unknown errors - Transmit to client if an unknown error occurs
Lms24
approved these changes
Jan 29, 2025
server/src/index.ts
Outdated
| () => { | ||
| res.set('Access-Control-Allow-Origin', '*'); | ||
| res.set('Access-Control-Allow-Methods', 'POST'); | ||
| res.set('Access-Control-Allow-Origin', '*'); |
Member
There was a problem hiding this comment.
l: why did we remove the startSpan call?
Contributor
Author
There was a problem hiding this comment.
hm, I forgot. Adding back...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.