-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat(middleware): extend deny middleware to deny based on prefix or suffix #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
untitaker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this be folded into deny-tag middleware? if not, i'd avoid introducing another verb "strip" and replace it with "deny" (deny-tag-substring or similar
Yes I think that should be possible. I will have a look. |
| starts_with: [foo] | ||
| ends_with: [bar] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking about calling this prefix/suffix, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinion, either is fine. i think the "best" API would be to impl glob support in deny-tag, but probably too complicated and possibly slow.
| starts_with: [foo] | ||
| ends_with: [bar] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong opinion, either is fine. i think the "best" API would be to impl glob support in deny-tag, but probably too complicated and possibly slow.
Extends the
deny-tagmiddleware to allow denying based on prefix or suffix.This PR extends the
deny-tagmiddleware that enables filtering of metric tag values by prefix and/or suffix. The primary use case is to reduce metric cardinality by automatically stripping common prefixes/suffixes from tag values in a centralized way.The main benefits are: