Fix getting the value of Constant (3.14 crash)#31
Merged
vmalloc merged 1 commit intogetslash:developfrom Oct 10, 2025
Merged
Conversation
`item.value` is a Constant here, and the attribute `.s` has been removed in Python 3.14, which makes this part crash. The attribute `.value` can now be used, which was in fact already used two lines above this change.
Member
|
Many thanks for your contribution! Much appreciated! |
Contributor
Author
|
Would it be possible for you to make a release? @vmalloc |
Member
|
@stgm sorry for the late response and thanks for the patience! I will release a new version today |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
item.valueis a Constant here, and the attribute.shas been removed in Python 3.14, which makes this part crash.The attribute
.valuecan now be used.Note: a similar correction was already done two lines above this change.