Skip to content

Conversation

@androidnisse
Copy link
Contributor

Summary

Test Plan

  • Started a game.

Checklist

  • Package was built and tested against unstable
  • This change could gainfully be listed in the weekly sync notes once merged

@androidnisse
Copy link
Contributor Author

Many thanks to @malfisya who created this package.yml

@EbonJaeger EbonJaeger added the Topic: Sync Notes This PR/Issue can be highlighted in sync notes label Nov 30, 2025
@malfisya
Copy link
Member

malfisya commented Dec 1, 2025

Can you use conflict instead of replace? I still would like lime3ds in the repo.

@EbonJaeger
Copy link
Member

Just as an additional note for reference, I tried to get it to use the system ffmpeg, too, but that fails with:

../src/core/dumping/ffmpeg_backend.cpp:959:10: error: use of undeclared identifier 'AV_OPT_TYPE_CHANNEL_LAYOUT'; did you mean 'AV_OPT_TYPE_CHLAYOUT'?
  959 |     case AV_OPT_TYPE_CHANNEL_LAYOUT: {
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |          AV_OPT_TYPE_CHLAYOUT
/usr/include/libavutil/opt.h:331:5: note: 'AV_OPT_TYPE_CHLAYOUT' declared here
  331 |     AV_OPT_TYPE_CHLAYOUT,
      |     ^
1 error generated.

@androidnisse androidnisse force-pushed the azahar branch 2 times, most recently from 4c07591 to 13548d5 Compare December 3, 2025 17:46
@EbonJaeger
Copy link
Member

Can you use conflict instead of replace? I still would like lime3ds in the repo.

I just noticed that Lime3DS has been archived upstream, and they point to this as the successor. What would be the reason for us keeping Lime3DS in our repo?

@androidnisse
Copy link
Contributor Author

Can you use conflict instead of replace? I still would like lime3ds in the repo.

I just noticed that Lime3DS has been archived upstream, and they point to this as the successor. What would be the reason for us keeping Lime3DS in our repo?

@malfisya

@androidnisse
Copy link
Contributor Author

Anything more that needs to be fixed here?

@malfisya
Copy link
Member

I just noticed that Lime3DS has been archived upstream, and they point to this as the successor. What would be the reason for us keeping Lime3DS in our repo?

It handles file type differently. Azahar is more strict compared to Lime3ds which is why I still use Lime3ds. I am hoping to keep Lime3ds for a bit longer.

Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could quickly install the project's license.txt file with the macro, we can get this in.

**Summary**
- Resolves getsolus#5500
Copy link
Member

@EbonJaeger EbonJaeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EbonJaeger EbonJaeger merged commit 18ac4f2 into getsolus:main Dec 14, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Solus Dec 14, 2025
@androidnisse androidnisse deleted the azahar branch December 26, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Topic: Sync Notes This PR/Issue can be highlighted in sync notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Azahar Emulator

4 participants