Add styling and add Nango branding #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the styling and adds Nango branding to the App component in the controller extension.
- Added Nango logo to
/src/entrypoints/popup/App.tsx, likely enhancing brand visibility - Modified layout in
App.tsx, potentially improving user interface and experience - Updated CSS classes in
App.tsx, suggesting refined styling for components - Possible changes to
/src/entrypoints/style.cssto support new branding elements - Maintained core functionality of the App component while focusing on visual improvements
1 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
src/entrypoints/popup/App.tsx
Outdated
Comment on lines
150
to
153
| <img src="/nango_logo.jpeg" alt="Nango Logo" className="w-8 h-8" /> | ||
| <p className="ml-4 pt-5 pb-4 text-center text-lg font-semibold"> | ||
| Connect to Nango | ||
| </p> |
There was a problem hiding this comment.
syntax: There's an extra space at the beginning of line 153, causing inconsistent indentation
src/entrypoints/popup/App.tsx
Outdated
| /> | ||
| <ScrollArea className="h-64 w-full overflow-y-auto"> | ||
| <div className="mb-3 grid w-full grid-cols-3 gap-3 p-3"> | ||
| <div className=" grid w-full grid-cols-3 gap-3 p-3"> |
There was a problem hiding this comment.
syntax: Extra space at the beginning of the className string
| </div> | ||
| </ScrollArea> | ||
| <div className="flex w-full justify-center px-4 pb-3"> | ||
| <div className="flex w-full justify-center px-4 pb-3 mt-5 cursor-pointer"> |
There was a problem hiding this comment.
style: Consider moving 'cursor-pointer' to the Button component for better semantics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge before Nango Demo