Repair slack query #31
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request introduces improvements to the Slack integration, focusing on channel name matching and asynchronous operations in the SlackClient class.
- Implemented Levenshtein distance-based channel name matching in
backend/app/connectors/client/slack.pyto handle slightly incorrect user inputs - Added asynchronous methods
get_all_channel_names()and_repair_channel_names()in SlackClient for improved channel name handling - Updated
backend/app/sandbox/integrations/slack.pyto use async operations, removing agent-based test code - Modified
backend/app/utils/levenshtein.pyto return the original string when no close match is found, potentially affecting error handling
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings
| for channel in channels | ||
| if channel["name"].lower() | ||
| in request_channel_names_set # Slack channel names are always lower case | ||
| if channel["name"] in request.channel_names |
There was a problem hiding this comment.
logic: This comparison is now case-sensitive. Ensure this is intended behavior
| async def _repair_channel_names( | ||
| self, request: SlackGetChannelIdRequest | ||
| ) -> SlackGetChannelIdRequest: | ||
| possible_channel_names: list[str] = await self.get_all_channel_names() |
There was a problem hiding this comment.
style: This call might be redundant if get_all_channel_ids() already fetched the channel list
Comment on lines
30
to
+31
| if ratio(most_similar, target) < THRESHOLD: | ||
| return None | ||
| return target |
There was a problem hiding this comment.
logic: This change could lead to unexpected behavior in calling code that expects None for no match. Ensure all usages of this function are updated accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.