Update the domain docs to show that force_ssl needs the host option set if you are using a custom domain#76
Open
mattgibson wants to merge 1 commit intogigalixir:mainfrom
Conversation
…on set if you are using a custom domain
jesseshieh
reviewed
Mar 9, 2021
Contributor
jesseshieh
left a comment
jesseshieh
left a comment
There was a problem hiding this comment.
I think in this case perhaps setting the host to nil might be better. My understanding is that if the host is new then it will redirect to HTTPS on the same host that came in. I think this is maybe set in other parts of the documentation, but it would be good to update this section also. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.