HEAL 120 add Firebase Crashlytics and Google Services to healthSDK by MozhganPeivandianSharbaf · Pull Request #877 · gini/gini-mobile-android

MozhganPeivandianSharbaf · 2026-02-02T15:05:45Z

Description

ticket is here

This branch fixes CI issues related to building the Health SDK example app by properly handling google-services.json.

The example app depends on Firebase, so a valid google-services.json is required whenever the example app is built (locally or in CI).
The file is now generated at build time using a GitHub secret and is excluded from version control.

Note: Anyone who wants to build the Health SDK example app must provide their own google-services.json.

Copilot

Pull request overview

This PR introduces Gradle plugin/version-catalog wiring intended to support adding Firebase Crashlytics and Google Services, and updates build configuration to use version-catalog aliases.

Changes:

Add pluginManagement repositories in settings.gradle.kts to enable resolving Gradle plugins from Google/Maven Central/Plugin Portal.
Add version-catalog entries for Firebase Crashlytics, Google Services, and SonarQube plugins and use aliases in the root build.gradle.kts.
Add a google-services.json file to the health SDK example app.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File	Description
settings.gradle.kts	Adds `pluginManagement` repositories for plugin resolution.
health-sdk/example-app/google-services.json	Adds Firebase configuration file for the example app.
gradle/libs.versions.toml	Adds plugin versions/aliases for Crashlytics, Google Services, and SonarQube.
build.gradle.kts	Switches to version-catalog aliases for plugin declarations (apply false).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

health-sdk/example-app/google-services.json

HEAL-120

…-services.json HEAL-120

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

.github/workflows/health-sdk.check.yml

health-sdk/example-app/build.gradle.kts

.github/workflows/health-sdk.publish.firebase.example.yml

…k.check.yml HEAL-120

sonarqubecloud · 2026-02-05T12:59:51Z

Quality Gate failed for 'Android Merchant SDK'

Failed conditions
10 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
2 New Critical Issues (required ≤ 0)
17 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

…dk publish firebase HEAL-120

sonarqubecloud · 2026-02-05T13:57:19Z

❌ The last analysis has failed.

See analysis details on SonarQube Cloud

… decoding process HEAL-120

…r in health-sdk.check.yml HEAL-120

HEAL-120

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…n step HEAL-120

sonarqubecloud · 2026-02-05T15:46:21Z

Quality Gate passed for 'Android Core API Library'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:47:49Z

Quality Gate passed for 'Android Health API Library'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:48:09Z

Quality Gate passed for 'Android Merchant SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:48:18Z

Quality Gate passed for 'Android Bank API Library'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:48:49Z

Quality Gate passed for 'Android Internal Payment SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:49:31Z

Quality Gate passed for 'Android Health SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:49:34Z

Quality Gate passed for 'Android Capture SDK'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud · 2026-02-05T15:52:17Z

Quality Gate failed for 'Android Bank SDK'

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Reliability Rating on New Code (required ≥ A)
41 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
6 New Critical Issues (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T16:08:48Z

.github/workflows/health-sdk.publish.firebase.example.yml

        uses: actions/checkout@v3
        with:
          fetch-depth: 3

      - name: setup java
        uses: actions/setup-java@v3
        with:
          distribution: 'temurin'
          java-version: '17'
          cache: 'gradle'


The actions versions are inconsistent with the health-sdk.check.yml workflow. The check workflow uses actions/checkout@v4 and actions/setup-java@v4 (lines 59 and 61 in health-sdk.check.yml), but this job uses v3 for both actions. For consistency and to use the latest stable versions, consider updating to v4:

actions/checkout@v4

actions/setup-java@v4

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-06T09:05:12Z

.github/workflows/health-sdk.check.yml

        required: true
+      GOOGLE_SERVICES_JSON_B64:
+        required: true


Making GOOGLE_SERVICES_JSON_B64 a required secret creates a breaking change for workflows that call this reusable workflow. Specifically, health-sdk.release.yml (lines 15-19) calls this workflow but doesn't pass this secret, which will cause release builds to fail.

Consider one of these approaches:

Make the secret optional by setting 'required: false' and handle the missing secret gracefully in the jobs that need it

Update health-sdk.release.yml to pass the GOOGLE_SERVICES_JSON_B64 and SONAR_TOKEN secrets (both are now required but SONAR_TOKEN is not passed either)

The same issue applies to SONAR_TOKEN which is also required but not passed by health-sdk.release.yml.

Suggested change

required: true

GOOGLE_SERVICES_JSON_B64:

required: true

required: false

GOOGLE_SERVICES_JSON_B64:

required: false

Copilot · 2026-02-06T09:05:13Z

health-sdk/example-app/build.gradle.kts

@@ -8,6 +8,8 @@ plugins {
    id("kotlin-parcelize")
    alias(libs.plugins.devtools.ksp)
    id ("org.sonarqube")


The sonarqube plugin is still using the old string literal format id ("org.sonarqube") instead of using the version catalog alias like in the root build.gradle.kts (which now uses alias(libs.plugins.sonarqube)).

For consistency with the root build file and the other plugins in this file (firebase.crashlytics, google.services, devtools.ksp), consider changing this to:

alias(libs.plugins.sonarqube)

This would ensure all plugin versions are consistently managed through the version catalog.

Copilot · 2026-02-06T09:05:13Z

.github/workflows/health-sdk.publish.firebase.example.yml

+  contents: write
+  packages: write


The permissions have been changed from "contents: read" to "contents: write" and "packages: write" has been added. These are overly broad permissions for a workflow that only builds and checks code without publishing anything.

The original "contents: read" permission was sufficient since this workflow only needs to read the repository code. Adding write permissions introduces unnecessary security risk if this workflow were ever compromised. Consider reverting these permission changes unless there's a specific requirement for write access.

Suggested change

contents: write

packages: write

contents: read

abolfazlimahdi

Looks good. Thank you!

MozhganPeivandianSharbaf requested a review from Copilot February 2, 2026 15:05

MozhganPeivandianSharbaf self-assigned this Feb 2, 2026

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 2, 2026 15:06 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

health-sdk/example-app/google-services.json Outdated Show resolved Hide resolved

feat(health-sdk): add Firebase Crashlytics and SonarQube dependencies

f9cdaae

HEAL-120

MozhganPeivandianSharbaf force-pushed the HEAL-120-Add-Crashlytics-to-the-example-app-for-Health-SDK branch from 9dd92b8 to f9cdaae Compare February 2, 2026 16:01

feat(health-sdk): integrate Firebase Crashlytics and configure google…

38e7fe4

…-services.json HEAL-120

MozhganPeivandianSharbaf requested a review from Copilot February 4, 2026 13:30

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 4, 2026 13:30 View session

Copilot AI reviewed Feb 4, 2026

View reviewed changes

.github/workflows/health-sdk.check.yml Show resolved Hide resolved

.github/workflows/health-sdk.check.yml Show resolved Hide resolved

health-sdk/example-app/build.gradle.kts Show resolved Hide resolved

.github/workflows/health-sdk.publish.firebase.example.yml Show resolved Hide resolved

fix(health-sdk): update permissions to read for contents in health-sd…

7916461

…k.check.yml HEAL-120

MozhganPeivandianSharbaf force-pushed the HEAL-120-Add-Crashlytics-to-the-example-app-for-Health-SDK branch from e0a6e11 to 7916461 Compare February 5, 2026 12:53

fix(health-sdk): update permissions to write for contents in health-s…

9be236e

…dk publish firebase HEAL-120

MozhganPeivandianSharbaf added 3 commits February 5, 2026 15:27

feat(health-sdk): add validation for google-services.json and improve…

e72ccec

… decoding process HEAL-120

feat(health-sdk): add GOOGLE_SERVICES_JSON_B64 as a required paramete…

86f9924

…r in health-sdk.check.yml HEAL-120

feat(health-sdk): add GOOGLE_SERVICES_JSON_B64

4c1dc1c

HEAL-120

MozhganPeivandianSharbaf requested a review from Copilot February 5, 2026 15:09

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 5, 2026 15:09 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

fix(health-sdk): streamline crashlytics creation and remove validatio…

a75ad05

…n step HEAL-120

MozhganPeivandianSharbaf requested review from abolfazlimahdi, Copilot and obaidgini February 5, 2026 15:56

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 5, 2026 16:04 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

MozhganPeivandianSharbaf requested a review from Copilot February 5, 2026 17:15

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 5, 2026 17:15 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

MozhganPeivandianSharbaf requested a review from Copilot February 6, 2026 08:58

Copilot started reviewing on behalf of MozhganPeivandianSharbaf February 6, 2026 08:59 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

abolfazlimahdi approved these changes Feb 6, 2026

View reviewed changes

Conversation

MozhganPeivandianSharbaf commented Feb 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate failed for 'Android Merchant SDK'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Core API Library'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Health API Library'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Merchant SDK'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Bank API Library'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Internal Payment SDK'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Health SDK'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate passed for 'Android Capture SDK'

Uh oh!

sonarqubecloud bot commented Feb 5, 2026

Quality Gate failed for 'Android Bank SDK'

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

abolfazlimahdi left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

MozhganPeivandianSharbaf commented Feb 2, 2026 •

edited

Loading