Rust: Use TypeItem in path resolution
#21133
Merged
+10
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors path resolution in Rust to use the recently introduced TypeItem class, consolidating code and reducing duplication. The TypeItem class represents items that define types (Struct, Enum, or Union) and provides common predicates for these types.
- Introduces
TypeItemTypeItemNodeas a generalized node type for all type items - Removes duplicate
EnumItemNodeandUnionItemNodeclasses that can be expressed using shared predicates - Refactors
StructItemNodeto extendTypeItemTypeItemNodewhile maintaining its special behavior
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR the new/recent
TypeItemclass is used in path resolution. It turned out thatUnionItemNodeandEnumItemNodecan be expressed only using the shared predicates inTypeItem.StructItemNodeis a bit special, so it's still there and overrides a few things fromTypeItemItemNode.The name
TypeItemTypeItemNodeis a bit clunky as Rust's notion of an "item" classes with path resolution's notion of an "item".