-
Notifications
You must be signed in to change notification settings - Fork 878
Breaking change: deny all permissions by default #509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
ca0e7f7
feat!: default-deny permissions across all SDK languages
SteveSandersonMS 07bdcd1
fix: add onPermissionRequest handlers to E2E tests for default-deny b…
SteveSandersonMS 7ba9d36
fix: add OnPermissionRequest handlers to Go hooks tests
SteveSandersonMS 64256b9
refactor: add PermissionHandlers.approveAll helper, remove verbose RE…
SteveSandersonMS a7bee9d
Rename PermissionHandlers to PermissionHandler across all SDK languages
SteveSandersonMS ae9a038
Fix ruff import sort in session.py
SteveSandersonMS 1135709
Node.js: export approveAll directly instead of PermissionHandler name…
SteveSandersonMS 2ade8c3
go fmt
SteveSandersonMS f124485
debug: log all events in default-deny test to inspect event structure
SteveSandersonMS 9941b3a
Fix default-deny e2e tests: check Permission denied in tool.execution…
SteveSandersonMS 6091fd7
fix: check error.message not result.content for permission denied det…
SteveSandersonMS 9ca4554
fix: move requestPermission outside config nil-guard in Go; add resum…
SteveSandersonMS a5cc0b7
fix: import PermissionHandler in Python e2e test
SteveSandersonMS 594196b
fix: remove redundant inline asyncio imports in Python e2e tests
SteveSandersonMS 63852b5
fix: add approveAll to invokes_built-in_tools test and regenerate sna…
SteveSandersonMS 8aa82f4
fix(go): add permission handler to abort test and regenerate snapshot
SteveSandersonMS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| /*--------------------------------------------------------------------------------------------- | ||
| * Copyright (c) Microsoft Corporation. All rights reserved. | ||
| *--------------------------------------------------------------------------------------------*/ | ||
|
|
||
| namespace GitHub.Copilot.SDK; | ||
|
|
||
| /// <summary>Provides pre-built <see cref="PermissionRequestHandler"/> implementations.</summary> | ||
| public static class PermissionHandler | ||
| { | ||
| /// <summary>A <see cref="PermissionRequestHandler"/> that approves all permission requests.</summary> | ||
| public static PermissionRequestHandler ApproveAll { get; } = | ||
| (_, _) => Task.FromResult(new PermissionRequestResult { Kind = "approved" }); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same documentation enhancement suggestion as for
SessionConfig.OnPermissionRequestabove - clarify the deny-by-default behavior.