Removing redundant params in params.merge()#323
Merged
Conversation
removes 2 redundant inclusions of params in a params.merge() call in reindex.rb
Contributor
There was a problem hiding this comment.
PR Overview
This pull request removes redundant inclusions of the params variable in the params.merge() calls within the reindex and rethrottle methods. The changes clean up unnecessary duplication in the method calls while keeping the original functionality intact.
- Removed duplicate params in reindex method's merge call.
- Removed duplicate params in rethrottle method's merge call.
Changes
| File | Description |
|---|---|
| lib/elastomer_client/client/reindex.rb | Removed redundant inclusion of params in merge calls for clarity. |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
jherns
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes 2 redundant inclusions of params in a params.merge() call in reindex.rb
** There are 2 failing tests that also fail on the main branch, unrelated to this change