feat(api): implement graphql merge query pattern to reduce api call volume #2478
+1,647
−479
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
Member
Author
|
Current state of this PR is functional, but needs some further polish / refactoring, and update tests before being ready |
setchy
changed the title
github-actions
bot
removed
the
enhancement
setchy
changed the title
github-actions
bot
added
the
enhancement
setchy
changed the title
afonsojramos
force-pushed
the
feat/query-merging
branch
2 times, most recently
from
d09207b to
02866a2
Compare
- Add query merging infrastructure to batch multiple GraphQL queries into one - Create BatchMergedDetailsQueryFragment for combined notification queries - Update handlers (Discussion, Issue, PullRequest) with mergeQueryConfig - Add INDEX suffix variable naming for merged query support - Create getNotificationAuthor helper to handle snake_case/camelCase formats - Guard against null URLs in notification enrichment - Update test mocks to use nodeINDEX response format Co-authored-by: Adam Setch <adam.setch@outlook.com>
- Remove commented-out debug code from notifications.ts - Fix FIXME by using isAnsweredDiscussionFeatureSupported with account - Remove unused extras field from GraphQLMergedQueryConfig type - Add mergeQueryConfig tests for issue, pullRequest, discussion, and default handlers - Document why integration test is skipped (complex mocking requirements)
afonsojramos
force-pushed
the
feat/query-merging
branch
from
c85feb4 to
27e5321
Compare
afonsojramos
previously approved these changes
Dec 30, 2025
Member
Author
|
@afonsojramos - this isn't ready yet, it's still very much a draft |
Member
|
Just wanted another pair of eyes! I'll keep working on this tomorrow 🙈 |
setchy
dismissed
afonsojramos’s stale review
Not ready yet, I have changed I'd like to make to it still...
Member
Author
What happened to my previous work on this branch, it seems you've rewrote the history and made other changes without discussion... I have local changes that I now need to untangle... |
Signed-off-by: Adam Setch <adam.setch@outlook.com>
…clash in merged query Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement GraphQL query aliasing and merging to reduce network calls and better utilize GitHub API rate limits
v6.14.1release buildFor Issues, Pull Requests or Discussions, full enrichment now occurs in a single API query with a maximum query cost of 4 units