Skip to content

Conversation

@afonsojramos
Copy link
Member

@afonsojramos afonsojramos commented Dec 30, 2025

Summary

Adds a new notification settings toggle to allow users to control whether read notifications are displayed or hidden in the application. Fixes #708.

Changes

  • Added showReadNotifications setting to control notification visibility
  • When enabled (default), displays both read and unread notifications
  • When disabled, hides read notifications until marked as done
  • Includes comprehensive filter logic and UI toggle in settings

Tests

  • Added filter tests for the new notification visibility logic
  • Added component test for the settings checkbox toggle

@github-actions github-actions bot added the enhancement New feature or enhancement to existing functionality label Dec 30, 2025
@afonsojramos afonsojramos linked an issue Dec 30, 2025 that may be closed by this pull request
@afonsojramos afonsojramos changed the title feat: add 'Show read notifications' setting (#708) feat: add 'Show read notifications' setting Dec 30, 2025
@setchy
Copy link
Member

setchy commented Dec 30, 2025

I've had this on my half-implemented list for a while, with a few raised and then closed PR attemps...

I think we need to wait until the merged/batched api is finished before merging to avoid rate limits.

Additionally, in the previous PRs I raised for this feature, I had changes to the HoverGroup buttons to hide the "mark as read" option on read NotificationRows

@sonarqubecloud
Copy link

@setchy
Copy link
Member

setchy commented Dec 30, 2025

We should also change the look and feel for read NotificationRows - ie: opacity difference, plus as Read State as a Filter Section option for Read and Unread.

Unfortunately the REST API doesn't indicate a difference between read and done notification types

@setchy
Copy link
Member

setchy commented Dec 30, 2025

Unfortunately the REST API doesn't indicate a difference between read and done notification types

To add some further thoughts for discussion, when I last looked into this feature ~2 months or so back that I was 80% convinced to close #708 as not planned since I couldn't see it being that useful alone unless we can find a way to differentiate read + done vs read and undone, or essentially the not done inbox. I timeboxed this but wasn't able to find any attributes within the public REST or GraphQL API endpoints that could help us here...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement to existing functionality

Development

Successfully merging this pull request may close these issues.

Feature request: add a "Show read notifications" setting

3 participants