Open
Conversation
Contributor
|
See #106 (comment). |
This was referenced Feb 1, 2026
Nelfimov
force-pushed
the
feat/config-dump
branch
from
929fb3f to
1abdc05
Compare
Contributor
|
@Nelfimov are you still working on the suggestion in #106 (comment)? Maybe it would make sense to close this PR and open a new one for that. |
tmandry
reviewed
Mar 5, 2026
Contributor
tmandry
left a comment
tmandry
left a comment
There was a problem hiding this comment.
A couple comments on the current branch in case you do pursue #106 (comment) based on it
| } | ||
|
|
||
| fn config_is_dumped() { | ||
| let file_name = "./glide.test.toml"; |
Contributor
There was a problem hiding this comment.
Glide depends on the tempfile crate for making temp test files. Please use that here.
|
|
||
| # macOS | ||
| .DS_Store/ | ||
| .DS_Store |
Contributor
Author
I wanted to finish it but lately was preparing for vacation so had to postpone. I plan to come back to later this month. It totally makes sense to start from scratch. Nevertheless wanted to say that I daily drive glide and am totally happy with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #106