Handle SERVICE_<port>_<type>_<metadata> encodings#668
Open
pmundt wants to merge 1 commit intogliderlabs:masterfrom
Open
Handle SERVICE_<port>_<type>_<metadata> encodings#668pmundt wants to merge 1 commit intogliderlabs:masterfrom
pmundt wants to merge 1 commit intogliderlabs:masterfrom
Conversation
At present SERVICE_<port>_<metadata> detection fails to account for the port type, which allows udp ports of ignored services to filter through. Fix this up by scanning for a port type designation and comparing this against the service port's type definition before determining how to proceed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present SERVICE__ detection fails to account for the
port type, which prevents selective filtering - e.g. of specific TCP or UDP ports
for individual services.
We can fix this up by scanning for a port type designation and comparing this
against the service port's type definition before determining how to proceed.
With this in place, we can now use any of:
SERVICE_xxx_TCP_IGNORE
SERVICE_xxx_TCP_NAME
SERVICE_xxx_UDP_IGNORE
SERVICE_xxx_UDP_NAME
...
for manipulating port-specific service metadata.
This should address issue #244