Skip to content

Adapt get predict table, renamed present/future climate to observed/projected climate#86

Open
merretbuurman wants to merge 14 commits intoglowabio:mainfrom
merretbuurman:adapt_get_predict_table
Open

Adapt get predict table, renamed present/future climate to observed/projected climate#86
merretbuurman wants to merge 14 commits intoglowabio:mainfrom
merretbuurman:adapt_get_predict_table

Conversation

@merretbuurman
Copy link
Collaborator

Renamed two download functions:

  • As discussed, renamed download_present_climate_tables() to download_observed_climate_tables()
  • As discussed, renamed download_future_climate_tables() to download_projected_climate_tables()

Modified get_predict_table():

  • Mainly, replaced list of accepted variables (which was outdated) by a call to the download_env functions.
  • Added a check whether input tables exist (because during testing, they didn't exist, and it failed without suitable error message)
  • Added some more output messages (will be displayed if quiet=FALSE)
  • Added output messages to bash script (will be displayed if quiet=FALSE)
  • I tested this locally and it worked.

Furthermore:

  • Started adapting some unit tests so that they load local dummy tables instead of downloading tables from server. To be continued.

Copy link
Contributor

@JaimeRi JaimeRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants