clear pulse interval when changing from visible to not visible#24
Open
wyattacedia wants to merge 1 commit intognestor:masterfrom
Open
clear pulse interval when changing from visible to not visible#24wyattacedia wants to merge 1 commit intognestor:masterfrom
wyattacedia wants to merge 1 commit intognestor:masterfrom
Conversation
Owner
|
Thanks @carlosalmonte04 for catching this. I'm so sorry I'm just seeing this now! I haven't done any React Native development for the past few years and I didn't receive an email notification from Github about this |
gnestor
requested changes
Jun 22, 2019
| } | ||
| }, PULSE_DURATION); | ||
| } else { | ||
| if (this.timer) { |
Owner
There was a problem hiding this comment.
Should this also be this.handleClearInterval()?
| @@ -1,5 +1,5 @@ | |||
| import React, { Component } from 'react'; | |||
Owner
There was a problem hiding this comment.
Can you revise this commit so that the only changes are the ones related to clearing the interval and not formatting?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise interval continues animating on native thread.
Visible by activating MessageQueue.spy (
MessageQueue.spy(true))