Do not crash if lpr is not available #377
Open
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probonopd
added a commit
to gershwin-desktop/libs-gui
that referenced
this pull request
Jan 2, 2026
Submitted upstream: gnustep#377
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds robust error handling to prevent application crashes when the lpr printing utility is not available on the system. The changes ensure graceful degradation with user-friendly error messages.
- Validates that
lprexists before attempting to use it - Wraps task launch in exception handling to catch runtime errors
- Shows informative alert panels to users when printing fails
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add error handling for the case when
lprcannot be found on the$PATH.