This repository was archived by the owner on Apr 12, 2019. It is now read-only.
Add Storage interface for different implementation of git tags#92
Open
lunny wants to merge 2 commits intogo-gitea:masterfrom
lunny:lunny/get_tag
Open
Add Storage interface for different implementation of git tags#92lunny wants to merge 2 commits intogo-gitea:masterfrom lunny:lunny/get_tag
lunny wants to merge 2 commits intogo-gitea:masterfrom
lunny:lunny/get_tag
Conversation
* Add support for packed-refs in GetTags() * Update comments
Member
|
CI failed |
bkcsoft
suggested changes
Nov 23, 2017
| // If both loose refs and packed refs exist then it's highly | ||
| // likely that the loose refs are more recent than packed (created | ||
| // on top of packed older refs). Therefore we can append each | ||
| // together taking the packed refs first. |
There was a problem hiding this comment.
We should not return duplicate refs. Especially not stale refs :(
| names := []string{} | ||
|
|
||
| for _, ref := range bytes.Split(refData, []byte("\n")) { | ||
| if tag := re.Find(ref); tag != nil { |
There was a problem hiding this comment.
How would this get the tag unreleased-beta-version ?
There was a problem hiding this comment.
and the regexp given above doesn't find any tags at all since it's broken :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also cherry-picked from github.com/gogits/git 16c37513c71a92abb31ffd8d8bd2308cb1016162.