Feature Request: io.Reader as attachment #149
Open
wshaman wants to merge 1 commit intogo-gomail:v2from
Open
Conversation
|
Nice idea, but I think it would be better to reuse the existing (appendFile) so that no dupplication here. It means changing What do you think ? :) |
|
@ahuret I have a file URL on a cloud server I want to attach to a mail. How do I implement this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short: Add io.Reader as attachment
Motivation: Using any cloud file storage (s3 in my case) you have to
We can reduce amount of conversions and keep code more straight-forward