fix: encode DEL (0x7f) control character#18
Conversation
spaceone
force-pushed
the
fix/escape-del-char
branch
from
8b511a8 to
db26491
Compare
spaceone
force-pushed
the
fix/escape-del-char
branch
from
db26491 to
9fd5298
Compare
encode DEL control characters in values, and remove them from keys. Fixes: 3f5ba89
spaceone
force-pushed
the
fix/escape-del-char
branch
from
9fd5298 to
0990210
Compare
|
Now, the DEL control char is also removed from a key, and a test case for both variants has been added. |
ChrisHines
changed the title
|
I don't understand what GitHub is doing. I was trying to pull in your latest changes to review them and somehow that resulted in merging two branches that were from different force pushes you did. But the most surprising thing is that somehow that managed to also put a merge commit into your fork! I've never seen that before. I think the safest thing here might be to close this PR and for you to submit a new PR with your latest version of the code so I can review the right code because whatever just happened broke your changes. Sorry about that. |
|
hm, let me check If I can fix it. |
spaceone
force-pushed
the
fix/escape-del-char
branch
from
7d9ecee to
0990210
Compare
|
@ChrisHines Forced pushed the correct state again. All tests are green. You should just be able to merge? |
ChrisHines
left a comment
ChrisHines
left a comment
There was a problem hiding this comment.
Ah, thanks. That cleaned up the weirdness.
2 participants
encode DEL control characters in values, and remove them from keys.
Fixes: 3f5ba89