Open
Conversation
ardhitama
commented
Sep 22, 2020
ardhitama
commented
- Add makefile to run sanity tests
- Fix lint errors
- Change the test redis namespace to use UUID to allow some tests to run in parallel
- Update the mod and remove proven benches since the one of bench causing mod error
…he time better before we able to run everything in parallel
adamrt
reviewed
Nov 30, 2020
There was a problem hiding this comment.
Edit: Sorry I was trying to comment on 250fcba
@ardhitama I was just browsing these PR commits and noticed particular one.
Can you elaborate on why you changed this? It might affect people that already depend on this behavior.
Thanks
Author
Thanks for noticing, this was to debug my particular need. Will remove this commit from the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.