Skip to content

Internally rename parent to collision_object in CollisionShape(2D/3D)#77971

Merged
akien-mga merged 1 commit intogodotengine:masterfrom
aaronfranke:col-shape-obj-name
Jun 8, 2023
Merged

Internally rename parent to collision_object in CollisionShape(2D/3D)#77971
akien-mga merged 1 commit intogodotengine:masterfrom
aaronfranke:col-shape-obj-name

Conversation

@aaronfranke
Copy link
Member

This is an internal rename to improve readability and clarity, split off from #77937 so we can merge this first.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aaronfranke
Copy link
Member Author

aaronfranke commented Jun 7, 2023

Heads up: I added one more small cleanup to this PR to only get the parent once in get_configuration_warnings(), but GitHub is not showing that change in the PR due to an outage. View here.

@aaronfranke aaronfranke force-pushed the col-shape-obj-name branch from 92c3bed to ec09cff Compare June 7, 2023 18:01
@akien-mga akien-mga added this to the 4.1 milestone Jun 8, 2023
@akien-mga akien-mga merged commit a440f0d into godotengine:master Jun 8, 2023
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants