fix: handle parent process exit to ensure MCP Server shutdown#33
Merged
fix: handle parent process exit to ensure MCP Server shutdown#33
Conversation
Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the MCP Server fails to shut down when the Claude Desktop process exits by adding a goroutine that monitors the parent process and signals shutdown.
- Added a goroutine to periodically check for parent process exit
- Sends a SIGTERM signal to trigger MCP Server shutdown when the parent process is detected as exited
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the Claude Desktop process exits, it does not send the
syscall.SIGTERMsignal to the MoLing MCP Server, causing MoLing to be unable to exit.Other MCP Clients do not have this issue, for example, Cherry Studio operates normally.