feat: update prompts for browser, command, and filesystem assistants#34
Merged
feat: update prompts for browser, command, and filesystem assistants#34
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces updates to improve prompt configuration and management across Browser, Command, and Filesystem services while also updating dependencies and resource cleanup.
- Centralized default prompt constants and external prompt file support have been added.
- Prompt-handling logic now utilizes dynamic configuration instead of hardcoded text.
- Dependency upgrades and minor CLI flag documentation improvements have been implemented.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| services/file_system_config.go | Adds default prompt constant & external prompt file support |
| services/file_system.go | Updates prompt handling to use the configured prompt |
| services/command_config.go | Introduces default prompt constant & external prompt file handling |
| services/command.go | Adapts prompt handling to use the configurable prompt |
| services/browser_config.go | Adds default prompt constant & external prompt file support |
| services/browser.go | Updates prompt handling and improves browser cleanup with timeout |
| cli/cmd/root.go | Updates CLI flag description for module naming consistency |
Files not reviewed (1)
- go.mod: Language not supported
…ules Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
8fa3881 to
6476c9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates aimed at improving the flexibility and maintainability of the configuration and prompt-handling mechanisms across multiple services (
BrowserServer,CommandServer, andFilesystemServer). The changes include replacing hardcoded prompts with configurable defaults, adding support for external prompt files, and updating dependencies.Prompt Configuration Enhancements:
BrowserPromptDefault,CommandPromptDefault,FileSystemPromptDefault) forBrowserServer,CommandServer, andFilesystemServerto improve maintainability. [1] [2] [3]PromptFilefield in configuration structs (BrowserConfig,CommandConfig,FileSystemConfig) to allow loading prompts from external files, with fallback to the default prompts. [1] [2] [3]handlePromptmethods to use the dynamically loaded prompt instead of hardcoded text. [1] [2] [3]Dependency Updates:
go.mod, includinggithub.com/mark3labs/mcp-go(v0.21.0 → v0.21.1) andgithub.com/go-json-experiment/json. Addedgithub.com/chromedp/cdprotoas a new dependency.Miscellaneous Improvements:
Closemethod ofBrowserServerby introducing a timeout for the Chrome context cancellation.moduleflag incli/cmd/root.goto use consistent capitalization for module names (e.g.,Browser,FileSystem).