feat: update command arguments and improve logging for service initialization#37
Merged
feat: update command arguments and improve logging for service initialization#37
Conversation
…lization Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors service request argument handling and improves logging in several service modules while updating dependencies and configurations. Key changes include refactoring argument extraction via request.GetArguments(), enhancing Chrome flags in browser initialization, and updating default command arguments.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/file_system.go | Replaced direct map access to use request.GetArguments() for file operations. |
| services/command.go | Updated command extraction to use request.GetArguments(). |
| services/browser_test.go | Modified test assignment for arguments. |
| services/browser_debugger.go | Updated debugger functions to use request.GetArguments(). |
| services/browser.go | Enhanced argument extraction and added additional Chrome flags. |
| go.mod | Updated dependency versions and added an indirect dependency. |
| client/client.go | Changed default Args from ["-m", "all"] to ["-m", "Browser"]. |
| cli/cmd/root.go | Improved logging with debug messages for module filtering. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several updates across multiple files, focusing on improving logging, updating dependencies, enhancing browser server functionality, and refactoring request argument handling. Below is a summary of the most important changes grouped by theme:
Logging Enhancements
mlsCommandFuncfunction incli/cmd/root.goto provide better visibility into module processing and service startup.Dependency Updates
go.mod, includinggithub.com/chromedp/cdproto,github.com/mark3labs/mcp-go, and others. Added a new indirect dependency ongithub.com/spf13/cast.Browser Server Improvements
services/browser.goby adding new Chrome flags (e.g.,disable-notifications,disable-dev-shm-usage) and conditional handling for headless mode.Refactoring Request Argument Handling
services/browser.go,services/browser_debugger.go,services/command.go, andservices/file_system.goto userequest.GetArguments()for extracting arguments, improving consistency and readability. [1] [2] [3] [4]Configuration Updates
Argsvalue inNewMCPServerConfigto["-m", "Browser"]inclient/client.go, aligning with the intended service behavior.