reduce ccd/multiccd memory with nccdmax/naccdmax#1116
Merged
thowell merged 4 commits intogoogle-deepmind:mainfrom Feb 11, 2026
Merged
reduce ccd/multiccd memory with nccdmax/naccdmax#1116thowell merged 4 commits intogoogle-deepmind:mainfrom
thowell merged 4 commits intogoogle-deepmind:mainfrom
Conversation
erikfrey
approved these changes
Feb 10, 2026
Collaborator
erikfrey
left a comment
There was a problem hiding this comment.
Really nice! Just a bunch of little nits.
Consider merging #1089 before this one as a courtesty to @adenzler-nvidia since he's been patiently waiting on that PR for a bit now
Collaborator
|
Actually reading #1089 sparked a million questions in my head, and I'm excited to discuss them with @adenzler-nvidia So maybe don't wait on that PR, let's get this one in |
Collaborator
|
Yes please don't worry about 1089, we'll get that in shape again after this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr introduces
nccdmax/naccdmaxsettings for reducing the memory requirements for ccd/multiccd. instead of allocating fields for epa and multicontact withnconmax/naconmax, allocate for the size of the ccd collider with the maximum contactsnccdmax/naccdmax.there are potentially significant memory savings for any scene that has a ccd collider and at least one other different collider (can be a primitive collider).
implementation from #966
SPS: 2,502,983 -> 2,505,272
total memory: 1466.00 MiB -> 1018.00 MiB