Conversation
|
Thanks for sharing - will try to dry-run this in newton. I think the direction looks good, we are using MjSpec. One thing that I'm failing to see on the first try is whether it's possible to control which world gets which randomization. I think that level of control would be useful, also for debugging. |
e6475dd to
a2c539c
Compare
a2c539c to
790b310
Compare
erikfrey
left a comment
There was a problem hiding this comment.
high level design: i really like this approach. it may be worth syncing with @adenzler-nvidia on whether we would want to specify a mapping per world explicitly, vs what you're doing here - i assume it's like a cartesian product or something?
my only suggestion is let's find some kind of naming convention in the custom tuples so it's obviously namespaced for this purpose. we may want to use custom tuples for other purposes too.
|
Unless it's technically impossible, I would vote for having the ability to specify the mapping explicitly. You never know what people want to be doing with this, and it seems like it makes sense to control this if needed. I didn't get to dry-run this yet because of release crunch but will do ASAP, hopefully still this week. |
790b310 to
41cd042
Compare
41cd042 to
25de185
Compare
update: the pr is now primarily about enabling batched
geom_dataid. see here for documentation (draft) containing examples utilizing this feature.per-world meshes
scene with 2 bodies
XML
Define via mjSpec