Open
Conversation
erikfrey
reviewed
Jan 6, 2026
Collaborator
erikfrey
left a comment
There was a problem hiding this comment.
Let's discuss how we want to design benchmarks going forward before we add this one. Might be time to make a few bigger changes.
| njmax = 64 | ||
|
|
||
|
|
||
| class MyoArm(benchmark.BenchmarkSuite): |
Collaborator
There was a problem hiding this comment.
Does this break running asv run main^! ?
Does the user have to manually run python get_myosim.py for the command above to work correctly?
Collaborator
Author
There was a problem hiding this comment.
yeah, probably need to run the script first
| _MYOSIM_COMMIT_SHA = "33f3ded946f55adbdcf963c99999587aadaf975f" | ||
|
|
||
|
|
||
| # TODO(team): shared utility with benchmark/kitchen/populate_scene._clone? |
Collaborator
There was a problem hiding this comment.
yes, in fact we should probably consider doing something like what playground does:
Perhaps it's time to support something like this so that we can keep these resources all outside of this repo.
Collaborator
Author
There was a problem hiding this comment.
created an issue #1001 for 'resource loader'
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add a benchmark for the MyoSim MyoArm musculoskeletal environment
a utility script benchmark/myosim/get_myosim.py is provided to clone MyoSim (pinned commit) from GitHub.
testspeed
note: the default
ccd_iterations(35) is too low and produces warningsairspeed velocity
todo
_clonea shared utility function?