Update Dockerfile so that image supports "make software".#210
Open
tcal-x wants to merge 2 commits intogoogle:mainfrom
Open
Update Dockerfile so that image supports "make software".#210tcal-x wants to merge 2 commits intogoogle:mainfrom
tcal-x wants to merge 2 commits intogoogle:mainfrom
Conversation
Collaborator
Author
|
@PiotrZierhoffer fyi |
added 2 commits
August 10, 2021 13:08
Signed-off-by: Tim Callahan <tcal@google.com>
These missing packages were discovered trying to build/run with docker. Signed-off-by: Tim Callahan <tcal@google.com>
Collaborator
Author
|
@PiotrZierhoffer , I noticed that the Dockerfile installs a list of all the needed apt packages itself, instead of relying on the call to ./scripts/setup. It would be nice to test the completeness of ./scripts/setup here. I realize we need to make sure 'git' is installed in order to clone the repo in order to get the setup script, but other than that, is there a reason we can't just use ./scripts/setup? And then do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into errors when I tried to run
cd proj/proj_template_v && make softwareinside a container running the generated image, so I changedmkdirtomkdir -p, and addedunzipandcurlto the installed packages.My commands to build and execute were:
and then
cdto proj/proj_template_v and runmake software.Signed-off-by: Tim Callahan tcal@google.com