Skip to content

Conversation

@3405691582
Copy link
Collaborator

This will not have any immediate effect, but this means new builds of the cuttlefish-defaults package will use cvdalloc when that package is installed.

This will not have any immediate effect, but this means new builds of
the cuttlefish-defaults package will use cvdalloc when that package is
installed.
@3405691582 3405691582 requested a review from Databean January 7, 2026 17:28
@@ -1,0 +1 @@
use_cvdalloc=true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case this ends up with unexpected breakage, would it be safer to first make sure cuttlefish-defaults is installed everywhere it should be before it starts introducing behavioral changes?

If cuttlefish-defaults doesn't intentionally introduce a behavioral change, it is less likely to be rolled back, and then the behavioral change of enabling cvdalloc by default would have a smaller rollback than "uninstall the package."

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessarily safer, but it's probably better all the same. I thought the change making cuttlefish-defaults a dependency of cuttlefish-common made it out to a release already, but it turns out it hadn't. I think this change in particular can sit on ice for a bit more.

@3405691582 3405691582 marked this pull request as draft January 8, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants