Conversation
- Migrated metadata from setup.cfg and setup.py to pyproject.toml. - Added support for uv via [dependency-groups]. - Updated Python version support to >= 3.8 for the library. - Used environment markers for development-only dependencies like JAX and mypy to ensure library standalone compatibility. - Updated resource loading in budoux/main.py to use standard library importlib.resources where available. - Removed legacy configuration files: setup.cfg, setup.py, and MANIFEST.in. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Added .flake8 to correctly configure style checks for 2-space indentation (since flake8 doesn't support pyproject.toml natively). - Fixed an incompatible type hint in budoux/main.py (Traversable vs Path). - Removed an unused import (pathlib.Path) in budoux/main.py. - Applied yapf reformatting to budoux/main.py. - Updated .flake8 to exclude .venv and other build directories. - Cleaned up redundant tool configuration in pyproject.toml. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
- Set requires-python = ">=3.10" in pyproject.toml. - Removed importlib-resources dependency. - Simplified budoux/main.py to use standard library importlib.resources directly. - Added .flake8 to maintain style rules for 2-space indentation. - Migrated all metadata and tool configurations to pyproject.toml where supported. - Cleaned up legacy setup.py, setup.cfg, and MANIFEST.in. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
- Migrated to pyproject.toml and removed legacy configuration files. - Dropped support for Python 3.8 and 3.9 (requires-python = ">=3.10"). - Simplified budoux/main.py to use standard library importlib.resources. - Refined types in budoux/main.py to use Traversable instead of Any. - Relaxed dependency version pins for better compatibility. - Added .flake8 to maintain project style rules. - Ensured all available data files are included in the package. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
- Migrated to pyproject.toml and removed setup.py/setup.cfg/MANIFEST.in. - Dropped Python 3.8/3.9 support. - Integrated with uv via [dependency-groups]. - Simplified resource loading in budoux/main.py using open() directly. - Maintained simple typing with Any for resource objects as requested. - Added .flake8 for style consistency. Co-authored-by: tushuhei <734905+tushuhei@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the repository to use modern Python package management standards.
Key changes:
pyproject.toml: All package metadata, build system requirements, and dependencies have been moved topyproject.toml.uvSupport: Added[dependency-groups]to support theuvpackage manager for development and testing.setup.py,setup.cfg, andMANIFEST.in.models/*.json,skip_nodes.json,py.typed,unicode_blocks.json) are correctly included via[tool.setuptools.package-data].Tests (both unit tests and JAX-based trainer tests) have been verified to pass using
uv run pytest.PR created automatically by Jules for task 13276904844649221747 started by @tushuhei