Skip to content

Default enable precision_preserving_double_format. #1885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −2
Open

Default enable precision_preserving_double_format. #1885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions conformance/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ _TESTS_TO_SKIP_MODERN = [
# configured timezone database.
"timestamps/timestamp_selectors_tz/getDayOfMonth_name_pos",
"timestamps/timestamp_selectors_tz/getDayOfYear",
# These depend on using charconv (or equivalent) to format doubles with shortest possible
# precision to preserve value. Not available on older compilers.
"conversions/string/double_hard",
]

_TESTS_TO_SKIP_MODERN_DASHBOARD = [
Expand Down Expand Up @@ -246,6 +249,9 @@ _TESTS_TO_SKIP_LEGACY = [
# configured timezone database.
"timestamps/timestamp_selectors_tz/getDayOfMonth_name_pos",
"timestamps/timestamp_selectors_tz/getDayOfYear",
# These depend on using charconv (or equivalent) to format doubles with shortest possible
# precision to preserve value. Not available on older compilers.
"conversions/string/double_hard",

# cel.@block
"block_ext/basic/optional_list",
Expand Down
2 changes: 1 addition & 1 deletion eval/public/cel_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ struct InterpreterOptions {
//
// Otherwise, will fall back to formatting with the worst-case required
// precision.
bool enable_precision_preserving_double_format = false;
bool enable_precision_preserving_double_format = true;
};
// LINT.ThenChange(//depot/google3/runtime/runtime_options.h)

Expand Down
2 changes: 1 addition & 1 deletion runtime/runtime_options.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ struct RuntimeOptions {
// precision.
//
// If disabled, will use the legacy behavior of rounding to 6 decimal places.
bool enable_precision_preserving_double_format = false;
bool enable_precision_preserving_double_format = true;
};
// LINT.ThenChange(//depot/google3/eval/public/cel_options.h)

Expand Down