Closed
Conversation
Collaborator
|
/gcbrun |
l46kok
reviewed
Mar 19, 2024
Collaborator
l46kok
left a comment
l46kok
left a comment
There was a problem hiding this comment.
Once PR is ready, could we regen these go files with 0.14? https://github.com/google/cel-spec/releases/tag/v0.14.0
l46kok
reviewed
Mar 19, 2024
| @@ -0,0 +1,8 @@ | |||
| module cel.dev/expr | |||
Collaborator
There was a problem hiding this comment.
@TristonianJones Thoughts on the directory structure? In case if you wanted to serve any other generated golang protos from here
Collaborator
There was a problem hiding this comment.
I don't have a lot of opinions on the directory structure; however, I also want to cut back on Go's reliance on proto in general, so I think having this single directory is pretty perfect for making sure that continues to be the case.
Member
Author
|
Superseded by #341. |
Member
Author
|
Correction: Superseded by #342. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Work in progress, do not merge.