This repository was archived by the owner on Dec 1, 2022. It is now read-only.
Added a constructor that passes the endpoint#168
Open
kberos wants to merge 1 commit intogoogle:masterfrom
Open
Added a constructor that passes the endpoint#168kberos wants to merge 1 commit intogoogle:masterfrom
kberos wants to merge 1 commit intogoogle:masterfrom
Conversation
…nstructor is used, it sets the Default GCM_SEND_ENDPOINT
Author
|
Created new pull request because I had different git commit email. I signed the agreement. Thanks, |
| String value) { | ||
| nonNull(body).append('&') | ||
| .append(nonNull(name)).append('=').append(nonNull(value)); | ||
| .append(nonNull(name)).append('=').append(nonNull(value)); |
Contributor
There was a problem hiding this comment.
Remove additional indentation please.
Contributor
|
Thanks, this looks like a reasonable addition, could you add a test before I merge? |
Contributor
|
Hi @kberos thanks again for the PR, if you can add those tests I'd be happy to merge. |
Contributor
|
Hi @kberos looking fwd to merging this PR once you add those tests, thanks. |
|
👍 This is needed for transition from GCM to FCM |
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need the flexibility to have a constructor that passes the endpoint to allow testing against a mock. The default original constructor applies the default GCM endpoint. The additional one allows to pass an endpoint of your choice.