compositor_vk: Increase descriptorCount safeguard for non-trivial descriptor consumption #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…criptor consumption ... and update the TODO with a better description of the issue.
aruby-blackberry
force-pushed
the
fix-compositor_vk-init
branch
from
c2336da to
284fada
Compare
aruby-blackberry
changed the title
Collaborator
Author
|
Latest CL addresses the real issue. Updated comment with better description of what would be needed to done to support this properly. |
jmacnak
reviewed
Jan 12, 2026
| // descriptorCount value here for use with combined image samplers must account for non-trivial | ||
| // descriptorCount consumption, otherwise some drivers are throwing VK_ERROR_OUT_OF_POOL_MEMORY. | ||
| // This information needs to be obtained from: | ||
| // VkSamplerYcbcrConversionImageFormatProperties::combinedImageSamplerDescriptorCount, or from |
Member
There was a problem hiding this comment.
I have an internal change in review (ag/37589469) that checks exactly this.
Collaborator
Author
There was a problem hiding this comment.
Internal ... arggh 😉
Member
There was a problem hiding this comment.
@aruby-blackberry can you confirm if 7ffe384 addresses?
Collaborator
Author
There was a problem hiding this comment.
Will give it a try today and report back, thank you!
Collaborator
Author
There was a problem hiding this comment.
@jmacnak This works, please merge into main. Thank you! 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.