ci: add windows tests #385
Open
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
would you plz review neild |
…is will ensure the diff command with process substitution runs correctly on Windows
…e gofmt failure on Windows. Please push the changes and check the CI again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added windows test and I noticed tests were failing so I fixed the tests too
minikube will be moving to use this library and we would like to ensure it has good testing coverage on windows. kubernetes/minikube#22456
The mustParseGolden helper reads the testdata/diffs golden file to verify test output. On Windows, where files are often checked out with CRLF line endings, the existing parser failed to correctly handle the carriage return (\r), leading to incorrect header keys (e.g., Key\r) and mismatched values.
This patch adds a normalization step to replace all \r\n sequences with \n immediately after reading the file. This ensures the parser works consistently regardless of the OS or Git line-ending configuration.