fix bug in using lexically scoped errors and add missing ctx in tests#198
Open
r0mflip wants to merge 1 commit intogoogle:masterfrom
Open
fix bug in using lexically scoped errors and add missing ctx in tests#198r0mflip wants to merge 1 commit intogoogle:masterfrom
r0mflip wants to merge 1 commit intogoogle:masterfrom
Conversation
|
|
||
| if err != nil { | ||
| return err | ||
| if rsErr != nil { |
Collaborator
There was a problem hiding this comment.
This loses the error from line 179. I think a better way to fix this would be to drop the predeclared outer err/rsErr entirely and instead pull the client.FindRepoSpec call out of the if-else block so that it only happens once. This seems to be what was actually intended, based on the fact that pi gets updated inside the if pi.Ver = "" case.
nguyen-phillip
requested changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.