Fix cluster sites not rendering #3430
Open
+187
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om threshold was crossed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3430 +/- ##
============================================
+ Coverage 69.91% 70.01% +0.09%
- Complexity 1599 1608 +9
============================================
Files 320 320
Lines 8590 8600 +10
Branches 945 945
============================================
+ Hits 6006 6021 +15
+ Misses 2010 2005 -5
Partials 574 574
🚀 New features to boost your workflow:
|
| super.shouldRender(oldClusters, newClusters) | ||
| } | ||
|
|
||
| private fun hasRenderingModeChanged(): Boolean = isClusterMode(oldZoom) != isClusterMode(zoom) |
Member
There was a problem hiding this comment.
Should we update the value of oldZoom in this method after it has returned true?
Collaborator
Author
There was a problem hiding this comment.
that value is updated by setZoom, which is called by each onCameraIdle. Then rendering related methods, such as this one, only consume that state to decide whether a re-render is needed
Member
There was a problem hiding this comment.
I was just wondering if there's a way to optimize things by re-rendering the clusters even if the zoom hasn't changed.
shobhitagarwal1612
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3387
There was an issue when zooming in on map clusters, where the individual items wouldn't render. This happened when the clusters themselves didn't change, but the zoom crossed the threshold where individual items should be displayed.
In order to fix that, a new override was added
shouldRenderwhich forces the rerender in this particular case, when the clusters don't change but the rendering type did.Before fix
Screen_recording_20260107_175849.webm
With fix
Screen_recording_20260107_175947.webm
@shobhitagarwal1612 PTAL?