Conversation
|
Onnxruntime was just upgraded on Feb 5th! It's been a while |
94318b9 to
5b93c9a
Compare
fmmoret
reviewed
Feb 11, 2026
a548cde to
8c67fc5
Compare
8c67fc5 to
4fe0d04
Compare
fmmoret
approved these changes
Feb 12, 2026
fmmoret
left a comment
There was a problem hiding this comment.
Curious about the higher numpy version but LGTM
Collaborator
Author
|
you mean the additional constraint on numpy? it seems uv had troubles selecting a proper version for it when on 3.14. It's a bit tricky because both magika and onnxruntime do depend on numpy. But I'm checking in #1268 whether we could get rid of this dependency, I don't think we really need it. Thanks for the feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked: onnxruntime does not yet support python 3.14.onnxruntime 1.24.1+ does support python 3.14
Fixes #1277.