Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request successfully removes the direct dependency on numpy, which is a great simplification. The changes in pyproject.toml and the removal of numpy imports are correct. The logic to replace numpy functions with pure Python equivalents in magika.py is also sound. I have one suggestion to improve the readability and maintainability of a loop that was refactored.
dbc2f19 to
1e755b0
Compare
1e755b0 to
6c85155
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1268.
There don't seem to be performance regressions. The mean inference time and other metrics are relatively noisy, but there doesn't seem to be a big change. Cherrypicked examples below.
Stats with
numpy(old version):Stats without
numpy(this new version):