android_device: update take_screenshot to support multiple displays #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xpconanfan
requested changes
May 23, 2025
Collaborator
xpconanfan
left a comment
xpconanfan
left a comment
There was a problem hiding this comment.
Need to add unit tests to cover the new scenarios
ko1in1u
reviewed
May 25, 2025
bbrother
force-pushed
the
test
branch
2 times, most recently
from
e9ab71d to
7523421
Compare
ko1in1u
previously approved these changes
May 27, 2025
xpconanfan
requested changes
May 28, 2025
ko1in1u
previously approved these changes
May 29, 2025
xpconanfan
requested changes
May 29, 2025
xpconanfan
approved these changes
Jun 2, 2025
ko1in1u
previously approved these changes
Jun 3, 2025
xpconanfan
requested changes
Jun 3, 2025
xpconanfan
requested changes
Jun 3, 2025
new all_displays arg to take_screenshot allows capturing a screenshot on all connected displays including internal
xpconanfan
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new all_displays arg to take_screenshot allows capturing a screenshot on all connected displays including internal
This change is