android_device: add BUILD_VERSION_SDK_FULL to AndroidProperties

[rpius]

This is the new versioning variable for minor API bumps

---

This change is 

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[xianyuanjia]

Resolve the CLA issue in https://cla.developers.google.com/

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions

---

mobly/controllers/android_device.py line 485 at r1 (raw file):

  )
  BUILD_VERSION_SDK = 'build_version_sdk', 'ro.build.version.sdk'
  BUILD_VERSION_SDK_FULL = 'build_version_sdk_full', 'ro.build.version.sdk_full'  

nit: remove whitespace

Code quote:

··

---

mobly/controllers/android_device.py line 485 at r1 (raw file):

  )
  BUILD_VERSION_SDK = 'build_version_sdk', 'ro.build.version.sdk'
  BUILD_VERSION_SDK_FULL = 'build_version_sdk_full', 'ro.build.version.sdk_full'  

This value is empty for SDK < 36 right? Could make a note of that here

Code quote:

  BUILD_VERSION_SDK_FULL = 'build_version_sdk_full', 'ro.build.version.sdk_full'

[xpconanfan]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rpius and @xianyuanjia)

---

mobly/controllers/android_device.py line 485 at r1 (raw file):

Previously, xianyuanjia wrote…

This value is empty for SDK < 36 right? Could make a note of that here

Would it return empty or would it cause error in the cmd?
If it's version specific, maybe we should only attempt to retrieve it above certain versions.

[xianyuanjia]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rpius and @xpconanfan)

---

mobly/controllers/android_device.py line 485 at r1 (raw file):

Previously, xpconanfan (Ang Li) wrote…

Would it return empty or would it cause error in the cmd?
If it's version specific, maybe we should only attempt to retrieve it above certain versions.

I tested it and the command returns empty. We can omit it from the final build_info if it doesn't have a value

[xpconanfan]

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @rpius and @xianyuanjia)

---

mobly/controllers/android_device.py line 485 at r1 (raw file):

Previously, xianyuanjia wrote…

I tested it and the command returns empty. We can omit it from the final build_info if it doesn't have a value

Guess it's ok to just leave it there as this is consistent with Android's own behavior (empty value)

[xpconanfan]

Reviewable status: 0 of 1 files reviewed, 3 unresolved discussions (waiting on @rpius and @xianyuanjia)

---

mobly/controllers/android_device.py line 57 at r1 (raw file):

    'ro.build.version.incremental',
    'ro.build.version.sdk',
    'ro.build.version.sdk_full',

should add an inline comment here with the context for this prop (only available above x version, and why we need it over the old one)

[rpius]

Moved to https://reviewable.io/reviews/google/mobly/978#