Allow loading snippets with the same package but different user IDs #994
Conversation
mhaoli
changed the title
| Raises: | ||
| Error, if a duplicated name or package is passed in. | ||
| Error: if a duplicated name or package is passed in. |
There was a problem hiding this comment.
the error message here should be updated as package name alone is no longer a differentiating factor?
|
|
||
| for snippet_name, client in self._snippet_clients.items(): | ||
| if package == client.package: | ||
| if package == client.package and new_snippet_user_id == client.user_id: |
There was a problem hiding this comment.
You are essentially replacing [package name] with [package name] + [user id] as the identifier for avoiding dup registration,
Wouldn't you need to store the id just like we are storing the package name today? Or you probably have a bug somewhere, or you'd have overly complicated logic
There was a problem hiding this comment.
Thanks for the suggestion. Created a separate PR #996 which adds a new property identifier for the snippet client and uses it for dup registration check. Could you help review it?
|
I've created PR #996 to support the same feature by adding a client identifier property. So closing this. |
2 participants
This is to relax the check in snippet_management_service to allow loading same snippet package with different user IDs.
With this CL, I verified that the same snippet app installed to different users can be loaded and used at the same time.