Don't allow loopback IP addresses for hosts

[gbrodman]

I don't know where in the spec these are explicitly disallowed, but it seems like good practice and we'll fail the RST tests if we don't disallow them.

---

This change is 

[CydeWeys]

@CydeWeys made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @gbrodman).

---

core/src/main/java/google/registry/flows/host/HostFlowUtils.java line 116 at r1 (raw file):

  public static void validateInetAddresses(ImmutableSet<InetAddress> inetAddresses)
      throws EppException {
    if (inetAddresses == null) {

No need for this. You're always passing in a minimum of an empty set. (See implementation of getInetAddresses())

[gbrodman]

@gbrodman made 1 comment.
Reviewable status: 0 of 5 files reviewed, 1 unresolved discussion (waiting on @CydeWeys).

---

core/src/main/java/google/registry/flows/host/HostFlowUtils.java line 116 at r1 (raw file):

Previously, CydeWeys (Ben McIlwain) wrote…

No need for this. You're always passing in a minimum of an empty set. (See implementation of getInetAddresses())

sure

[CydeWeys]

@CydeWeys resolved 1 discussion.
Reviewable status: 0 of 5 files reviewed, all discussions resolved.

[CydeWeys]

@CydeWeys reviewed 5 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @gbrodman).

[gbrodman]

actually inetAddresses can be null, e.g. https://github.com/google/nomulus/blob/master/core/src/main/java/google/registry/model/host/HostCommand.java#L57

@gbrodman made 1 comment.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @CydeWeys).

[CydeWeys]

@CydeWeys made 1 comment.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @gbrodman).

---

core/src/main/java/google/registry/flows/host/HostFlowUtils.java line 114 at r3 (raw file):

  /** Makes sure that no provided IP addresses are local / loopback addresses. */
  public static void validateInetAddresses(ImmutableSet<InetAddress> inetAddresses)

Mark param with @Nullable then.